-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily Re-Introduce Studio Maintenance Announcements #36107
base: master
Are you sure you want to change the base?
Conversation
d5b8d3a
to
2f57a9d
Compare
93ec261
to
23fe895
Compare
Sandbox deployment successful 🚀 |
23fe895
to
38254dd
Compare
Converting back to draft since the announcements don't seem to be showing up on the learner dashboard for some reason...https://pr-36107-139931.sandboxes.opencraft.hosting/dashboard @Agrendalath , if you see something obviously wrong with this, let me know. Otherwise I'll try to fix it later today or tomorrow. |
Sandbox deployment failed 💥 |
Ah, I need to turn on ENABLE_ANNOUNCEMENTS |
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
…)" This reverts commit 9274852.
Co-Authored-By: Feanil Patel <feanil@axim.org>
38254dd
to
d8c77fa
Compare
@Agrendalath OK, this is actually ready now. The PR sandbox is not working, but I have verified the change locally and included screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdmccormick, thank you for preparing this!
👍
- I tested this: verified that the announcements can be edited in Studio and are displayed correctly on the legacy dashboard
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
Description
This PR has two commits:
The net result is that we are temporarily re-introducing just the Announcements tool within the Studio Maintenance dashboard, as well as the "Maintenance" link in the Studio header. The "Maintenance" link in the MFE header will be re-introded in a quick follow-up PR, which also needs review and approval: openedx/frontend-component-header#565
Supporting information
See discussion: #35852 (comment)
Screenshots & testing instructions
Set
FEATURES['ENABLE_ANNOUNCEMENTS'] = True
, and then disable the learner home MFE via waffle (/admin/waffle/flag/?q=learner_home_mfe
).Go to the restored maintenance dashboard in Studio. Notes:
<CMS_BASE>/maintenance
.Create few new announcements. Make at least one active, and one inactive:
Ensure the active ones show up on the legacy learner dashboard (at
<LMS_BASE>/
):Please note that the janky image and text formatting was an existing behavior, and is part of why we desire to remove this feature from the platform soon.