-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "build: Python requirements upgrade and lxml build without binary" #34661
Revert "build: Python requirements upgrade and lxml build without binary" #34661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
feat!: upgrading pymongo to 4.0 fix: Update Makefile feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat: Upgrade Python dependency enmerkar-underscore Update to a Python 3.11 compatible version Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` feat: Upgrade Python dependency edx-codejail Update to a Python 3.11 compatible version Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` Revert "build: Python requirements upgrade and lxml build without binary (openedx#34…" (openedx#34661) This reverts commit 52adce4 because we were getting this in the build pipeline: ``` WARNING: lxml 5.2.1 does not provide the extra 'html-clean' ERROR: Exception: Traceback (most recent call last): File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 173, in _main status = self.run(options, args) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/cli/req_command.py", line 203, in wrapper return func(self, options, args) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 315, in run requirement_set = resolver.resolve( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 94, in resolve result = self._result = resolver.resolve( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 472, in resolve state = resolution.resolve(requirements, max_rounds=max_rounds) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 366, in resolve failure_causes = self._attempt_to_pin_criterion(name) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 221, in _attempt_to_pin_criterion satisfied = all( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 222, in <genexpr> self._p.is_satisfied_by(requirement=r, candidate=candidate) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/provider.py", line 178, in is_satisfied_by return requirement.is_satisfied_by(candidate) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/requirements.py", line 84, in is_satisfied_by assert candidate.name == self.name, ( AssertionError: Internal issue: Candidate is not for this requirement lxml[html-clean,html-clean] vs lxml[html-clean] WARNING: You are using pip version 21.2.1; however, version 24.0 is available. You should consider upgrading via the '/edx/app/edxapp/venvs/edxapp/bin/python -m pip install --upgrade pip' command. ```
Reverts #34655 because we were getting this in the build pipeline: