Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix lxml constraint issue #34652

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: fix lxml constraint issue #34652

merged 4 commits into from
Apr 30, 2024

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Apr 29, 2024 •
edited
Loading

Description

  • pin lxml versin again in constraints to resolve failures introduced in last PR
  • Updating lxml constraint caused the build pipeline to fail due to the new system dependencies requirement.

@UsamaSadiq UsamaSadiq marked this pull request as ready for review April 29, 2024 12:47
@UsamaSadiq UsamaSadiq closed this Apr 29, 2024
@UsamaSadiq UsamaSadiq reopened this Apr 30, 2024
iamsobanjaved
iamsobanjaved approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change in constraint comment, rest good.

UsamaSadiq and others added 4 commits April 30, 2024 19:34
@UsamaSadiq
fix: pin lxml<5.0 version
108c8ff
@github-actions @UsamaSadiq
feat: Upgrade Python dependency lxml (#34651)
51735a0 
Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`

Co-authored-by: UsamaSadiq <UsamaSadiq@users.noreply.github.com>
@UsamaSadiq
fix: fix inconsistent requirements
b2d3ca3
@UsamaSadiq
fix: update lxml constraint comment
44ae5c8
@UsamaSadiq UsamaSadiq force-pushed the fix-lxml-constraint-issue branch from 06c646e to 44ae5c8 Compare April 30, 2024 14:38
@UsamaSadiq UsamaSadiq merged commit 188e486 into master Apr 30, 2024
66 checks passed
@UsamaSadiq UsamaSadiq deleted the fix-lxml-constraint-issue branch April 30, 2024 15:08
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UsamaSadiq @edx-pipeline-bot @iamsobanjaved