Set initial video quality to large instead of default to avoid automatic switch to HD when iframe resizes. [BLD 981] #3447
Conversation
|
Do we need some test for this change? |
|
@polesye It's a minor change. But I will add a test to check that |
|
Just check that initial value is 'large'. |
|
@polesye Added a test. |
|
It works well in all browsers except Safari. But there is an issue of youtube API. |
|
👍 |
|
hmm..looks like this test doesn't make sense and you was right with checking that |
|
@polesye I just tested it again with Safari 6.1.3 on OSX 10.7.5, it looks like it works, I cannot reproduce the bug when I follow the steps outlined in: |
|
@polesye I will modify the test. |
|
@jmclaus Click play button -> adjust the speed of any other except 1st -> change quality. And you'll see that video continue playing from the start on 1st speed. |
|
@polesye Yes, I could reproduce it. But this should be a different ticket. Should I file one on Jira? |
|
There was one BLD-977. I think, we should wait for the fix from Youtube team. What do you think? |
…tic switch to HD when iframe resizes. [BLD 981]
|
@polesye Yes, we should wait for the fix instead of hacking around the issue. I just added the modified test, rebased and squashed commits. Good to merge? @valera-rozuvan Please review this when you have time. |
|
@jmclaus Looks good! Good to merge! 👍 |
|
👍 |
…by_itself Set initial video quality to large instead of default to avoid automatic switch to HD when iframe resizes. [BLD 981]
@polesye @valera-rozuvan Please review.