Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds very basic about page style to ul, ol and dl #3435

Merged
merged 1 commit into from
May 2, 2014

Conversation

caesar2164
Copy link
Contributor

About pages need basic support for lists since professors often want to display lists or 'definitions'

@caesar2164
Copy link
Contributor Author

@talbs, @frrrances & @singingwolfboy - here's the clean PR (new branch superseding #3403)

Example of about page that needs lists and definitions:
(Notice the "Learning Objectives" UL, "Table of Contents" DL, and "Disclosures" profile DL)

Before:
screen shot 2014-04-28 at 10 27 05 am

After:
screen shot 2014-04-22 at 2 51 38 pm

@caesar2164
Copy link
Contributor Author

Ok, @talbs, @frrrances - you guys were right the previous change was messing with menus and such.

Modified this PR to make changes only happen on about pages now.

@frrrances
Copy link
Contributor

lgtm 👍

About pages need basic support for lists since professors often want to display lists or 'definitions'
caesar2164 added a commit that referenced this pull request May 2, 2014
Adds very basic about page style to ul, ol and dl
@caesar2164 caesar2164 merged commit 3ff3973 into openedx:master May 2, 2014
@caesar2164 caesar2164 deleted the giulio/ul-ol-basic-style branch May 2, 2014 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants