Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feanil/reset all passwords #3312

Closed
wants to merge 81 commits into from
Closed

Feanil/reset all passwords #3312

wants to merge 81 commits into from

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Apr 10, 2014

No description provided.

FiloSottile and others added 30 commits April 5, 2014 18:13
@FiloSottile
Add SHOW_PROGRESS_SUCCESS_BUTTON feature
da5ab6d 
Show a button at the top of lms/templates/courseware/progress.html if the
lowest nonzero grade cutoff has been reached. Introduce two settings:
PROGRESS_SUCCESS_BUTTON_URL is the href of that button (the course id is
appended); PROGRESS_SUCCESS_BUTTON_TEXT is the text, defaults to
"Download your certificate"
@FiloSottile
Make the SHOW_PROGRESS_SUCCESS_BUTTON feature more flexible
1ce7a24 
The button text default is now in the template and i18n-able, a
PROGRESS_SUCCESS_BUTTON_TEXT_OVERRIDE option is offered in settings.
The button url now uses string formatting.
@carsongee
Add test in import code to make sure two overlapping courses aren't i…
4844a50 
…mported
@carsongee
Refactored terminology and added loop break for optimization
13af6fc
@carsongee
Switch PDF Textbooks to use portable URLs
6136ed2
@fmyzjs
install and set up paver before using it
2231d6c 
install and set up paver before using it
@fmyzjs
install and set up paver before using it
fca915c 
install and set up paver before using it
@singingwolfboy
Added process documentation
4db7f33
@singingwolfboy
Refer to process docs in CONTRIBUTING.rst
ac1e566
@singingwolfboy
Include analytics team in dev process
09f8923
@singingwolfboy
link to docs to rebase a pull request
44e4f96
@singingwolfboy
Added a visualization of the PR process
4bc3ec2
@singingwolfboy
core committers, not contributors
ab5a2a4
@singingwolfboy
Add example for how scrum teams spend time reviewing contributor pull…
99897c4 
… requests
@singingwolfboy
remove duplicate "should"
05e5564
add acceptance tests for user profile pagination.
f71e78b 
JIRA: FOR-492
@srpearce
Experiment with cell widths to see if images will appear
3c9b79d
@srpearce
Merge pull request #3461 from edx/sylvia/docs/table_images
e629e88 
Experiment with cell widths to see if images will appear
@mhoeber
DOC-275, location & Language columns
b7c7575 
additional small typos and fixes
@mhoeber
Merge pull request #3448 from edx/ahodges/documentation/DOC275
6686eb5 
DOC-275, location & Language columns
@singingwolfboy
Merge pull request #3460 from edx/release
d1d3e6b 
Merging release back to master
Wait that all resources are loaded and fragments rendered before init…
4d1d1a7 
…ializing the xblock
Merge pull request #3458 from edx/jsa/user-profile-pagination-acceptance
bf56d30 
add acceptance tests for user profile pagination.
Changes for batch add beta testers feature
bb4b547
@srpearce
Add information about per-criterion feedback
e714409
Merge pull request #3390 from edx/ahodges/documentation/LMS2476
1e2adc6 
Ahodges/documentation/lms2476
Removed evil HEAD line
015b1c3
Merge pull request #3468 from edx/ahodges/documentation/chglogchgs
6994f25 
Removed evil HEAD line
@mhoeber
HTML Editor Changes - Raw Editor
a75b6ea 
stud-1566
@mhoeber
Merge pull request #3454 from edx/markhoeber/documentation/stud-1566
dead780 
HTML Editor Changes - Raw Editor
singingwolfboy and others added 19 commits April 25, 2014 16:03
@singingwolfboy
Merge pull request #3145 from carsongee/cg/course_import_validation
7aa627b 
Add test in import code to make sure two overlapping courses aren't imported
@marcotuts
Merge pull request #2810 from edx/marco/discussions/styling-cleanup
a15e43f 
Forums visual styling adjustments
@srpearce
Add info about removing prompt
3671b91
@srpearce
Correct copy/paste error in Adaptive Hint section
cc892d6
@srpearce
Merge pull request #3479 from edx/sylvia/docs/DOC-345
b38a923 
Correct copy/paste error in Adaptive Hint section
@johncox-google
Fix acceptance tests
0379bd3
@singingwolfboy
Merge pull request #2780 from FiloSottile/progress_success_button
5edae3e 
Show a success button at the top of the Progress page
@johncox-google
Update changelog
441055d
@nedbat
Merge pull request #3450 from johncox-google/johncox/feature/buttons
82bd46d 
Change signin control from text list to buttons.
@sarina
Correct native spelling of Armenian language
cb59040
Release for Apr 27, 2014
c9f707f
@sarina
Update how translations are pulled
3422fcf
@sarina
Update translations (autogenerated message)
5118809
@sarina
Merge pull request #3484 from edx/sarina/042914-language-update
4800811 
Sarina/042914 language update
Merge pull request #3483 from edx/ora2/release-2014-04-27T20.17
37cb005 
Release for Apr 27, 2014
@muhammad-ammar
Merge pull request #3440 from edx/ammar/config-youtube-stub-for-bok-choy
dfa45ea 
Configure youtube stub for bok-choy
@singingwolfboy
Merge pull request #3434 from edx/db/dev-process
73c30e9 
Document our development/review process
@srpearce
Merge pull request #3478 from edx/sylvia/docs/TIM-476
e4c5eb4 
Add info about removing prompt
@sarina
Merge pull request #3438 from edx/sarina/fix-video-i18n
7a51382 
Don't scrape unnecessary strings for i18n
@feanil
Copy link
Contributor Author

feanil commented Apr 28, 2014

@singingwolfboy It was originally added to be able to reset password after heartbleed if we decided to do that. I'm going to re-base this off of master in case we need this logic in the future.

@singingwolfboy
Copy link
Contributor

@feanil so there's no intent to actually get this merged into master right now, is that correct? If that's the case, can this pull request be closed?

@feanil
Copy link
Contributor Author

feanil commented Apr 28, 2014

no sorry I was not clear, I'm going to re-base this work from master and get it reviewed so it can be merged into master. We may need this feature in the future so I want it in place if we do.

@singingwolfboy
Copy link
Contributor

@feanil Gotcha. Who needs to review this pull request? (You can just apply the relevant labels onto the pull request -- this is a new organizational scheme I'm starting to implement.)

@feanil
Add a feature be able to do mass password resets.
49a5d56 
If an 'OLDEST_VALID_PASSWORD_TIME' is defined, any passwords that are older
will need to be reset.
@feanil
Copy link
Contributor Author

feanil commented Apr 28, 2014

Closing this, will re-open against master when I have some time to work on this.

@feanil feanil closed this Apr 28, 2014
@benpatterson benpatterson deleted the feanil/reset_all_passwords branch January 21, 2015 13:10
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@baby636 baby636 mentioned this pull request Mar 22, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feanil feanil

Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.