Change behavior of cohort addition interface #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [(user, self.cohort2.name) for user in self.cohort2_users] + | ||
| [(user, self.cohort3.name) for user in self.cohort3_users] | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Unless this is already enforced by a db constraint, I think it would be good to have an assertion, somewhere, that users were actually removed from their previous cohorts when changed to a new cohort.
|
apart from test coverage request, 👍 |
|
Updated; I will squash before merging |
|
👍 |
Instead of noting users that are already in a cohort and not changing such users, clobber the previous cohort and display a message indicating the previous cohort membership. JIRA: FOR-452
gwprice
pushed a commit
that referenced
this pull request
Apr 7, 2014
Change behavior of cohort addition interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of noting users that are already in a cohort and not changing
such users, clobber the previous cohort and display a message indicating
the previous cohort membership.
JIRA: FOR-452
@jimabramson