Alex/fix more flaky tests #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auraz We should get Jenkins to run this PR a couple of times. This comment should be updated with all Jenkins jobs launched for this PR: Auto PR Manual PR |
| @@ -14,6 +14,8 @@ | |||
| "lti": {"port": settings.LTI_PORT, "class": StubLtiService}, | |||
| } | |||
|
|
|||
| YOUTUBE_API_RESPONSE = requests.get('http://www.youtube.com/iframe_api') | |||
There was a problem hiding this comment.
Is it possible not to use external service and mock this request?
There was a problem hiding this comment.
We need real youtube API to initialize videos. In case we will stub it, we need to update when youtube update it. And this is not possible.
|
👍 once Jenkins pass. |
|
👍 after tests pass. |
|
@auraz Squash commits, rebase against latest master. 👍 Good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up youtube stub server by loading youtube api only once.
This PR contains https://github.com/edx/edx-platform/pull/3149
Reviewers:
@polesye
@valera-rozuvan
@olmar