chore: disable forum digest subscription section by default #31459
Conversation
|
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
6d305ee to
6526876
Compare
Current State of the feature Initially, this feature used the Notifier Django app but was deprecated and removed from the configuration in favor of edx-notifications. More info about this deprecation can be found in the GitHub issue ( openedx/wg-build-test-release#22). The edx-notifications app was not supported though, so its repository was archived and moved to openedx-unsupported/edx-notifications. Check the deprecation ticket (openedx-unsupported/edx-notifications#253) and corresponding discussion (https://discuss.openedx.org/t/deprecation-removal-edx-notifications-repository/6748) for details. What remains in the edx-platform The forum initial page contains the how-to info with the notification preferences toggle. This section is responsible for toggling the "notification_pref" user preference (aka NOTIFICATION_PREF_KEY). I didn't find any usage of this preference across the platform, so I'm suggesting hiding it by default by setting the ENABLE_FORUM_DAILY_DIGEST setting to `False`.
6526876 to
e39df94
Compare
|
Hi @jristau1984! Would you mind reviewing this? @jmakowski1123 - we will still get this into product review - do you know who will be looking at it from the product side? |
|
Hi @jristau1984 and @jmakowski1123! Friendly ping on reviewing this from both Eng and Prod sides. Thanks! |
|
Thanks for the contribution @dyudyunov ! I'd like Aamir Ayub (product manager for discussions) to review this, because the status of the "notification_pref" may have changed with the recent updates to the Discussions Forums that are currently available in Olive. I've created a Feature Ticket here, and will connect Aamir to complete the product review on this ticket. Thanks! |
|
Changes proposed in this PR make sense to me. In the next 3-6 months, forum notifications will be configureable from a dedicated preference interface in the platform. UX is still under development. |
|
Thanks @ayub02 ! @mphilbrick211 This Feature Ticket has completed its product review. |
|
Hi @jristau1984 -if this looks Ok to you would you mind merging? Thanks! @asadazam93 flagging this for you too in case you're able to review/merge. Thank you! |
|
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Current state of the feature
Initially, this feature used the Notifier Django app but was deprecated and removed from the configuration in favor of edx-notifications. More info about this deprecation can be found in the GitHub issue.
The edx-notifications app was not supported though, so its repository was archived and moved to GitHub - openedx-unsupported/edx-notifications. Check the deprecation ticket and corresponding discussion for details.
What remains in the edx-platform
The forum's initial page contains the how-to info with the notification preferences toggle:
This section is responsible for toggling the "notification_pref" user preference (aka NOTIFICATION_PREF_KEY). I didn't find any usage of this preference across the platform, so I'm suggesting hiding it by default by setting the ENABLE_FORUM_DAILY_DIGEST setting default value to
False.The result will look like
