Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AA-304] Create backend for three day streak celebration #26409

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

MatthewPiatetsky
Copy link
Contributor

@MatthewPiatetsky MatthewPiatetsky commented Feb 5, 2021

Learning MFE PR
Jira Ticket

When making calls to the courseware_api or course_home_api, this feature will check whether a streak should be celebrated and will return the result within the celebrations dict in the response. The streak data will be updated in the database if necessary as part of this check.

This feature uses the first_day_of_streak and last_day_of_streak fields to determine whether the user should see a celebration.

For example:

date first_day_of_streak last_day_of_streak streak_length_to_celebrate
2/4/21 2/4/21 2/4/21 None
2/5/21 2/4/21 2/5/21 None
2/6/21 2/4/21 2/6/21 3

The longest_ever_streak field keeps track of the longest ever streak for potential future use in badging.

@MatthewPiatetsky MatthewPiatetsky force-pushed the AA-304 branch 9 times, most recently from cae9613 to 9ea8b62 Compare February 8, 2021 14:12
@openedx openedx deleted a comment from edx-status-bot Feb 8, 2021
@MatthewPiatetsky MatthewPiatetsky changed the title ignore for now [WIP] [AA-304] Create backend for three day streak celebration Feb 8, 2021
@MatthewPiatetsky MatthewPiatetsky force-pushed the AA-304 branch 4 times, most recently from 85c65da to 62a70de Compare February 9, 2021 16:55
@openedx openedx deleted a comment from edx-status-bot Feb 9, 2021
@openedx openedx deleted a comment from edx-status-bot Feb 19, 2021
@MatthewPiatetsky MatthewPiatetsky force-pushed the AA-304 branch 4 times, most recently from 66e2933 to 4c6176b Compare February 19, 2021 18:35
Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for putting up with all those comments

@MatthewPiatetsky MatthewPiatetsky force-pushed the AA-304 branch 2 times, most recently from fb329c7 to d7002e2 Compare February 22, 2021 15:20
This feature uses the first_day_of_streak, last_day_of_streak and last_streak_celebration fields to determine whether the user should see a celebration.
AA-304
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@MatthewPiatetsky MatthewPiatetsky merged commit 789af8d into master Feb 22, 2021
@MatthewPiatetsky MatthewPiatetsky deleted the AA-304 branch February 22, 2021 16:19
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants