Adds Logistration MFE url for forgot password email. #25476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainab-amir
reviewed
Oct 29, 2020
common/djangoapps/student/forms.py
Outdated
Comment on lines
41
to
43
| logistration_mfe_enabled = configuration_helpers.get_value( | ||
| 'ENABLE_LOGISTRATION_MICROFRONTEND', settings.FEATURES.get('ENABLE_LOGISTRATION_MICROFRONTEND') | ||
| ) | ||
| site_name = settings.LOGISTRATION_MICROFRONTEND_URL.split('//')[1] if logistration_mfe_enabled \ | ||
| else configuration_helpers.get_value('SITE_NAME', settings.SITE_NAME) |
There was a problem hiding this comment.
should_redirect_to_logistration_mircrofrontend() util function can be used. Also maybe we can save the logistration MFE domain name in a setting instead of calling split
Suggested change
| logistration_mfe_enabled = configuration_helpers.get_value( | |
| 'ENABLE_LOGISTRATION_MICROFRONTEND', settings.FEATURES.get('ENABLE_LOGISTRATION_MICROFRONTEND') | |
| ) | |
| site_name = settings.LOGISTRATION_MICROFRONTEND_URL.split('//')[1] if logistration_mfe_enabled \ | |
| else configuration_helpers.get_value('SITE_NAME', settings.SITE_NAME) | |
| site_name = settings.LOGISTRATION_MICROFRONTEND_URL_DOMAIN if should_redirect_to_logistration_mircrofrontend() \ | |
| else configuration_helpers.get_value('SITE_NAME', settings.SITE_NAME) |
This patch would enable routing learner to logistration MFE via forgot password url than on platform when ENABLE_LOGISTRATION_MICROFRONTEND feature flag is set. VAN-98
25b6c1c to
d61936f
Compare
|
Your PR has finished running tests. There were no failures. |
zainab-amir
approved these changes
Oct 29, 2020
uzairr
approved these changes
Nov 2, 2020
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch would enable routing learner to logistration MFE
via forgot password url than on platform when
ENABLE_LOGISTRATION_MICROFRONTEND feature flag is set.
VAN-98