Rewrite Reference and ReferenceList fields on import #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffcover is lying-- the "Reference" code is covered by test_rewrite_reference (verified with breakpoint in debugger). |
| tag=target_location_namespace.tag, | ||
| org=target_location_namespace.org, | ||
| course=target_location_namespace.course | ||
| ).url() |
There was a problem hiding this comment.
The spacing makes this hard to read. I'd format this more like:
if (original_location.tag == ref.tag and
original_location.org == ref.org and
original_location.course == ref.course):
new_ref = ref.replace(
tag=target_location_namespace.tag,
org=target_location_namespace.org,
course=target_location_namespace.course
).url()or
def locations_equal(a, b):
return (a.tag == b.tag and a.org == b.org and a.course == b.course)
if locations_equal(original_location, ref):
new_ref = ref.replace(
tag=target_location_namespace.tag,
org=target_location_namespace.org,
course=target_location_namespace.course
).url()|
Again, only nitpicks, so 👍. As for diffcover, you should probably file a bug report with @wedaly. |
|
👍 |
cahrens
pushed a commit
that referenced
this pull request
Feb 12, 2014
Rewrite Reference and ReferenceList fields on import
|
Filed https://edx-wiki.atlassian.net/browse/TE-346 for diffcover bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes STUD-149.
@dmitchell @singingwolfboy Please review. This branch is based off of #2503, so the first commit can be ignored (assuming you reviewed the other one!).