pep8/pylint cleanup on symmath/formula.py #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI here are the Pylint violations remaining: https://gist.github.com/sarina/8918758 |
|
I've taken my best quick swag at it with doing anything to risky. |
|
Looks like tests are failing because I put the file docstring above the encoding line. I've changed that around, will wait for tests to be re-run and see if that fixes the errors. |
sarina
added a commit
that referenced
this pull request
Feb 11, 2014
pep8/pylint cleanup on symmath/formula.py
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 26, 2018
* Instructor, course staff and course scorer can access courses whose terminate dates have already passed. openedx#2478-1 * Add ga_extract_data_authority role. openedx#2478-3 * Beta testers also can access instructor dashboard. openedx#2478-2 * Fix tests. openedx#2478 * Add beta testers to bulk email recipients. openedx#2478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carsongee this file has an absurd amount of pep8 & pylint violations.
I cleaned up the pep8 and took a stab at some Pylint. Would you mind looking these over?
If you have a spare 15 minutes, could you add a commit that further cleans up Pylint by adding docstrings to functions? I don't know this code well but it's used by MIT so I'm hoping you can help.