-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish wiki i18n #2488
Finish wiki i18n #2488
Conversation
@sarina @cpennington your opinions are valued, as always. |
@@ -0,0 +1,2 @@ | |||
[python: **.py] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki has templates too - see eg https://github.com/edx/django-wiki/blob/master/wiki/templates/wiki/deleted.html
{% trans "The article you were looking for has been deleted." %}
OK, I updated the commit to extract from the .html files in the wiki app as well. Note this pulls in some files we don't care about. Bleh. |
Adding the extract of .html actually didn't improve much as far as I can tell. There's still a lot of holes. |
I added many tweaks to get the i18n done. I'll have to also change the git hash for django-wiki once this PR is merged: openedx/django-wiki#2 |
This looks good. Can you check in the esperanto files for the wiki? |
string = string.replace(k, v) | ||
return string | ||
for old, new in self.TABLE.items(): | ||
string = string.replace(old, new) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would using this be clearer? http://docs.python.org/2/library/stdtypes.html#str.translate
Modulo comments: 👍 |
We use pybabel to extract strings from third-party apps, put them on Transifex, then merge them into django.po. [LMS-1681]
We use pybabel to extract strings from third-party apps, put them on
Transifex, then merge them into django.po.
[LMS-1681]