Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish wiki i18n #2488

Merged
merged 5 commits into from
Feb 10, 2014
Merged

Finish wiki i18n #2488

merged 5 commits into from
Feb 10, 2014

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Feb 6, 2014

We use pybabel to extract strings from third-party apps, put them on
Transifex, then merge them into django.po.

[LMS-1681]

@nedbat
Copy link
Contributor Author

nedbat commented Feb 6, 2014

@sarina @cpennington your opinions are valued, as always.

@nedbat nedbat mentioned this pull request Feb 6, 2014
@@ -0,0 +1,2 @@
[python: **.py]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki has templates too - see eg https://github.com/edx/django-wiki/blob/master/wiki/templates/wiki/deleted.html

{% trans "The article you were looking for has been deleted." %}

@nedbat
Copy link
Contributor Author

nedbat commented Feb 6, 2014

OK, I updated the commit to extract from the .html files in the wiki app as well. Note this pulls in some files we don't care about. Bleh.

@nedbat
Copy link
Contributor Author

nedbat commented Feb 10, 2014

I added many tweaks to get the i18n done. I'll have to also change the git hash for django-wiki once this PR is merged: openedx/django-wiki#2

@sarina
Copy link
Contributor

sarina commented Feb 10, 2014

This looks good. Can you check in the esperanto files for the wiki?

string = string.replace(k, v)
return string
for old, new in self.TABLE.items():
string = string.replace(old, new)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpennington
Copy link
Contributor

Modulo comments: 👍

nedbat added a commit that referenced this pull request Feb 10, 2014
@nedbat nedbat merged commit ce5fd88 into master Feb 10, 2014
@nedbat nedbat deleted the ned/i18n-for-wiki branch February 10, 2014 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants