edited CME cert name and fixed dashboard display (DO NOT MERGE) #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| % if course.may_certify() and cert_status and not enrollment.mode == 'audit': | ||
| <%include file='_dashboard_certificate_information.html' args='cert_status=cert_status,course=course, enrollment=enrollment'/> | ||
| % if course.may_certify() and cert_status['status'] != 'processing' or course.has_ended() and cert_status and not enrollment.mode == 'audit': | ||
| <%include file='_dashboard_certificate_information.html' args='cert_status=cert_status,course=course, enrollment=enrollment'/> |
There was a problem hiding this comment.
What's up with weird whitespace around cert_status near eol?
|
@jrbl - one more look? (I've added all the code that was missing…) |
| if settings.FEATURES.get('USE_CME_REGISTRATION', False): | ||
| cert_text = "CME Certificate" | ||
| else: | ||
| cert_text = "{certtext}" |
There was a problem hiding this comment.
Under what circumstances do you imagine certtext and USE_CME_REGISTRATION both being set, and the contents of certtext being something other than "CME Certificate"?
There was a problem hiding this comment.
@jrbl - the circumstance when I search and replace without thinking...
|
@sefk - can I put this branch on the CME server and do some testing on it? (If it all goes well it would go into next release…) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrbl