Move tests related to views files into views/tests. #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -332,17 +332,6 @@ def save_subs_to_store(self, subs, subs_id): | |||
| del_cached_content(content_location) | |||
| return content_location | |||
|
|
|||
| def remove_subs_from_store(self, subs_id): | |||
There was a problem hiding this comment.
These methods are unused because the tests are calling a method (with the same name) in transcripts_utils. So it appears that the author just forgot to delete these methods when creating the utility method.
|
👍 ⭐ 💃 😃 👍 🎆 ✨ 👍 👍 👍 |
|
❤️ 😍 ❤️ |
|
This is waiting on #2356 to merge first. |
|
For any interested parties, I removed some unused imports introduced by @dmitchell in #2356. |
cahrens
pushed a commit
that referenced
this pull request
Feb 10, 2014
Move tests related to views files into views/tests.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 23, 2018
* Add ORA2 video upload option openedx#2375 (openedx#2417) * Modified courseware page look and feel openedx#2377 (openedx#2409) * Modified about page openedx#2379 (openedx#2413) * Fix biz bugs. openedx#2404 (openedx#2406) * Fix display width of popup. (openedx#2384) (cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95) * Validate duplicate url-code. * Fix bug, when course not found. * Fix order of course as CourseOverview. * Remove additional-info count from contract grid. openedx#2419 (openedx#2437) * Fix order global course. openedx#2420 (openedx#2421) * Add additional info register. openedx#2419 (openedx#2433) * fix survey csv character encode problem openedx#2380 (openedx#2434) * Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457) * Fix register students confirm message. (openedx#2461) * Add command to check playback_log. openedx#2438 (openedx#2445) * Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453) * Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467) * Fix bugs. openedx#2462 openedx#2463 (openedx#2464) * Fix password message in register students page. * Fix glass pane of processing when register additional item. * Fix display width of popup. (openedx#2466) * Fix min-width of sequence-nav. openedx#2468 (openedx#2469) * Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@singingwolfboy Can you review this cleanup PR? I was adding a new test for a file in contentstore.views, and I was annoyed that the tests for those files live in contentstore.tests instead of contentstore.views.tests. So I decided to move the existing tests (at least the ones that obviously map to a file in contentstore.views).
I also did some pep8 cleanup.