Make LMS use runtime.service("i18n") for i18n. #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2014 13:56
The django.utils.translation module has the right interface to serve as a gettext.Translations object, so we use it for the runtime i18n service. LMS-1597
|
@sarina @cpennington Please review. |
|
It's a little strange to have |
|
👍 🐈 🐒 💸 🌴 🔌 💻 🏣 📯 📮 |
|
@nedbat it looks like the two lms acceptance tests both hung on your build (https://jenkins.testeng.edx.org/job/edx-all-tests-auto-pr/3400/?) I'm kicking off another one manually to see if that fixes it. |
|
@cpennington XModule does use i18n. XModuleDescriptor does not (yet). |
|
Individual XModules use i18n. The base class doesn't. |
nedbat
added a commit
that referenced
this pull request
Jan 9, 2014
Make LMS use runtime.service("i18n") for i18n.
shimulch
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Mar 15, 2021
YONK-1920 - Merge Juniper release changes in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMS-1597