Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0d/fix conflicts #1955

Closed
wants to merge 11 commits into from
Closed

E0d/fix conflicts #1955

wants to merge 11 commits into from

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Dec 13, 2013

@adampalay @jarv @dmitchell @wedaly @jzoldak

This branch resolved merge conflict between master and release. Can you please review. The tests failed, but they've been failing for a bit today, so I'm not sure if this is related

We can't have a new rc until we get to the bottom of these conflicts.

@e0d
Copy link
Contributor Author

e0d commented Dec 13, 2013

Conflicts that were resolved favoring head in both cases.

diff --cc cms/templates/js/transcripts/messages/transcripts-uploaded.underscore
index 9895d7f,c17d83f..0000000
--- a/cms/templates/js/transcripts/messages/transcripts-uploaded.underscore
+++ b/cms/templates/js/transcripts/messages/transcripts-uploaded.underscore
@@@ -10,7 -10,7 +10,11 @@@
      <button class="action setting-upload" type="button" name="setting-upload" 
          <span><%= gettext("Upload New Timed Transcript") %></span>
      </button>
++<<<<<<< HEAD
 +    <a class="action setting-download" href="/transcripts/download?locator=<%=
++=======
+     <a class="action setting-download" href="/transcripts/download?locator=<%=
++>>>>>>> origin/release
          <span><%= gettext("Download to Edit") %></span>
      </a>
  </div>
diff --cc cms/djangoapps/auth/authz.py
index a5d00e1,5ec7beb..0000000
--- a/cms/djangoapps/auth/authz.py
+++ b/cms/djangoapps/auth/authz.py
@@@ -265,8 -262,8 +262,13 @@@ def is_user_in_creator_group(user)
          return False

      # Feature flag for using the creator group setting. Will be removed once t
++<<<<<<< HEAD
 +    if settings.FEATURES.get('ENABLE_CREATOR_GROUP', False):
 +        return user.groups.filter(name=COURSE_CREATOR_GROUP_NAME).count() > 0
++=======
+     if settings.MITX_FEATURES.get('ENABLE_CREATOR_GROUP', False):
+         return user.groups.filter(name=COURSE_CREATOR_GROUP_NAME).exists()
++>>>>>>> origin/release

      return True

@wedaly
Copy link
Contributor

wedaly commented Dec 14, 2013

The tests are failing because collectstatic broke with this PR: https://github.com/edx/edx-platform/pull/1889
I'm not sure the best way to back out those changes.

@wedaly wedaly closed this Dec 14, 2013
@wedaly wedaly reopened this Dec 14, 2013
@dmitchell
Copy link
Contributor

For authz, it should be

if settings.FEATURES.get('ENABLE_CREATOR_GROUP', False):
    return user.groups.filter(name=COURSE_CREATOR_GROUP_NAME).exists()

That is, one line from HEAD and one from branch. I don't know if it makes much of a difference (a slightly faster sql query for exists than count).

I'm not really sure about transcripts-uploaded.underscore but believe HEAD is the safer bet (the snippet above doesn't show the conflict but I recall resolving it locally as well that way).

@e0d e0d closed this Dec 16, 2013
@e0d e0d deleted the e0d/fix_conflicts branch December 16, 2013 15:17
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Jun 23, 2017
* Fix gap of biz-menu. openedx#1939

* Fix message to save mail-template. openedx#1938

* Fix message to send test-mail. openedx#1934

* Fix current menu of mail management. openedx#1955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants