-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Feature to close courses and block learner access #18907
Proposal: Feature to close courses and block learner access #18907
Conversation
Thanks for the pull request, @lgp171188! I've created OSPR-2605 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
@marcotuts @shamck Could you take a look at this proposal? |
@marcotuts @shamck did you get a chance to review this proposal? @mduboseedx |
Hello! I will be taking a look at this and should have a reply back next week. Thanks! |
@marcotuts Thanks, that's good news :) Were you able to take a look at this? |
@marcotuts, did you get a chance to take a look at this? |
1 similar comment
@marcotuts, did you get a chance to take a look at this? |
@marcotuts, greetings! Did you get a chance to look at this? |
Your PR has finished running tests. The following contexts failed:
|
Hello! This is something I will need to run by @sstack22 and her engineering team as they have been thinking about access / gating / dates. Apologies for the delay, I did not reach out internally to get this input when I should have. |
I have scheduled time next week to review with Shelby. Thanks! |
@lgp171188 - Can you help us understand the intent of this feature, and when authors might choose to do this? What situations arise that require closing a course? Is it always at the end of a course run so that access can be clearly cut off before the course is deleted? Is it in support of other workflow needs? Related / Potential Use Cases: |
@marcotuts, thanks for reviewing this proposal.
This is the requirement from the client - after the course end date, the course content should not be accessible. The current behaviour of archiving courses after the end date still allows access to the course content. We are looking at a way to override the behaviour to close the course instead. Tying this new behaviour to the course end date will change the current way it behaves. So if that is not okay, we are also okay with ideas to implement a separate "Close the course" action or a "Close the course after date" action. This could be implemented at a per-course level, per site-level and also as a configuration setting. |
@marcotuts, did you get a chance to check my response to your questions? Do you have any other questions or concerns? |
@marcotuts, ping! Did you get a chance to check my response to your questions? Do you have any other questions or concerns? |
@lgp171188 Sorry for delay, we will try to look into this soon. |
Thanks for the details here, in summary it sounds like your use case is most aligned to "#3"
From a product standpoint I suppose what I'm proposing is that rather than add another date to the course, I would add an option for the behavior that happens at Course End. On course end the default behavior would be "Archive: Course remains accessible to students thought it is clearly labeled as being archived / unmonitored to set learner expectations." A new second option (behind a waffle flag) would let you see this option control and have "Close: Course is no longer viewable after course end date." See attached draft image for the way this would be expressed on the Schedule & Details page. Thoughts on this? We believe this is preferable to adding another date to the course authoring experience. (Note the red block with the new "Course End Behavior" |
@marcotuts, thanks for the inputs on the way to implement this. The approach you have suggested and the screenshot that you have posted in your comment fully matches our requirements and we have no concerns on implementing this. After we get the approval from the client on this, we will start working on the implementation and get back with a PR containing the changes. Thanks! |
@lgp171188 Do you still need this PR open? |
@natabene, this PR can be closed as it is just for a proposal. |
@lgp171188 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This feature will make it possible to close a course which will block learner access to the closed course. A per-course 'Close course' setting will be provided to close the course or re-open access to the course. Currently, course authors achieve this by moving the course start date to the far future which can be confusing and is a misleading use of the feature. The error message shown when the learner tries to access that course is also misleading.
The functionality of blocking access to the course will be similar to the behavior when the course start date is in the future. The student dashboard will still display the course in the student dashboard but without any links to the blocked course. Navigating to the course content directly by URL will redirect the student to the dashboard page with an appropriate error message.
Most of the code changes to implement this feature will have to be done in the
courseware
module. There are existing checks in that module which check for the course start date and block access if it is in the future. Additional checks can be added for implementing this feature.Dependencies: None
Merge deadline: None
Reviewers
CC @mduboseedx, requesting a review for this proposal.