Revert "Pass DOM element, not jQuery object to XBlock initialisation." #11674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 makes sense to revert this until you're ready with the better fix. Sorry I missed this issue in the review, and of course there are no tests for the problem builder block to catch it. |
|
jenkins run lettuce |
|
👍 I tested locally on my devstack with the Problem Builder version currently used by edx-platform, and everything works fine. |
bradenmacdonald
added a commit
that referenced
this pull request
Feb 26, 2016
…block Revert "Pass DOM element, not jQuery object to XBlock initialisation."
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts edx/edx-platform#11433 because the one-line change to
common/static/js/xblock/core.jshas broken the Problem Builder XBlock in LMS and Studio. (It's now passing a jQueryelementfrom theruntime.children()JS call, which is inconsistent with the other fixes in that PR). Since this has broken an XBlock used in courses, I am proposing this revert as a quick fix, and will follow up with a re-implemented version of #11433.JIRA: https://openedx.atlassian.net/browse/TNL-4161
Verification: