Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy this doc up from the bok_choy tests. #11519

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

jibsheet
Copy link
Contributor

It's just as relevant to unit tests and I wish I had seen it earlier (this is where I originally learned about --pdb which was super helpful for all my test debugging, but I was doing awful things to trigger the debugger from tests, like raise Exception('kevin') since a normal import pdb doesn't work under nose).

@benpatterson @jzoldak

@benpatterson
Copy link
Contributor

👍

@@ -270,6 +270,13 @@ will drop you into pdb on error. This lets you go up and down the stack
and see what the values of the variables are. Check out `the pdb
documentation <http://docs.python.org/library/pdb.html>`__

Use this command to put a debugging breakpoint in a test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should point out that if someone actually checks in this code, his/her test will hang (i.e., don't check it in).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up wording changes for this one (and copied them to the second doc of this feature).

@jzoldak
Copy link
Contributor

jzoldak commented Feb 12, 2016

👍

It's just as relevant to unit tests and I wish I had seen it earlier.

Stress the transient nature of this debugging step.
@jibsheet jibsheet force-pushed the jibsheet/document-nose-breakpoints-twice branch from 3cf1d61 to 21b75f8 Compare February 12, 2016 15:27
jibsheet added a commit that referenced this pull request Feb 12, 2016
…-twice

Copy this doc up from the bok_choy tests.
@jibsheet jibsheet merged commit 4037b16 into master Feb 12, 2016
@jibsheet jibsheet deleted the jibsheet/document-nose-breakpoints-twice branch February 12, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants