MA-1985 add analytics event to thread/comment vote #11450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9631e1d to
3076776
Compare
|
@jcdyer @nasthagiri kindly review |
| @@ -515,6 +516,7 @@ def _do_extra_actions(api_content, cc_content, request_fields, actions_form, con | |||
| else: | |||
| context["cc_requester"].unvote(cc_content) | |||
| api_content["vote_count"] -= 1 | |||
| track_voted_event(request, context["course"], cc_content, "up", False if form_value else True) | |||
There was a problem hiding this comment.
Lots of opaque args. Use kwargs instead. request and context are self-documenting, but "up" and the boolean are particularly hard to understand, and cc_content only slightly easier.
|
(pass complete) |
b0d66e6 to
88b3f2d
Compare
|
@jcdyer updated |
|
@muzaffaryousaf @symbolist @muhammad-ammar need one more reviewer on this |
| @@ -9,6 +9,7 @@ | |||
| from django.core.urlresolvers import reverse | |||
| from django.http import Http404 | |||
| import itertools | |||
| from lms.djangoapps.django_comment_client.base.views import track_voted_event | |||
There was a problem hiding this comment.
There are imports for the track functions on line 29. Can you merge this with those?
|
@wajeeha-khalid We should add tests to verify that the correct event data is emitted. I see some tests for the other events in |
|
@wajeeha-khalid I have completed a pass. |
88b3f2d to
7bfda1d
Compare
7bfda1d to
72aeb2c
Compare
|
jenkins run bokchoy |
|
@jcdyer @symbolist incorporated feedback |
|
👍 |
1 similar comment
|
👍 |
wajeeha-khalid
added a commit
that referenced
this pull request
Feb 12, 2016
MA-1985 add analytics event to thread/comment vote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MA-1985 add analytics event to thread/comment vote