PdfViewer: Added missing link to compatibility.js #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me 👍 |
|
👍 Seems pretty clearly stated. |
|
👍 |
symbolist
added a commit
that referenced
this pull request
Sep 27, 2013
PdfViewer: Added missing link to compatibility.js
lgp171188
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Sep 20, 2018
Merge development into integration
cocococosti
pushed a commit
to Pearson-Advance/edx-platform
that referenced
this pull request
Aug 18, 2020
PE-785 - Adding custom course home feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://edx-wiki.atlassian.net/browse/LMS-1167
compatibility.js is needed for the pdf viewer to work in IE as per https://github.com/mozilla/pdf.js. Just added the missing link to the template.
@frrrances, @brianhw please review.