Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Bump jackson-databind version to 2.10.5.1 #984

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Bump jackson-databind version to 2.10.5.1 #984

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8153136
initial commit, save progress
davidcui1225 Jan 12, 2021
0adc6b0
forcing jackson core to use v2.10.5
davidcui1225 Jan 12, 2021
e0d0627
forcing updated version of jackson-core vs excluding
davidcui1225 Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions elasticsearch/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ dependencies {
compile project(':core')
compile group: 'org.elasticsearch', name: 'elasticsearch', version: "${es_version}"
compile "io.github.resilience4j:resilience4j-retry:1.5.0"
compile group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.10.4'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.4'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.10.5'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.5.1'
compile group: 'org.json', name: 'json', version:'20180813'
compileOnly group: 'org.elasticsearch.client', name: 'elasticsearch-rest-high-level-client', version: "${es_version}"

Expand Down
1 change: 1 addition & 0 deletions integ-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ configurations.all {
// enforce 1.1.3, https://www.whitesourcesoftware.com/vulnerability-database/WS-2019-0379
resolutionStrategy.force 'commons-codec:commons-codec:1.13'
resolutionStrategy.force 'com.google.guava:guava:29.0-jre'
resolutionStrategy.force 'com.fasterxml.jackson.core:jackson-core:2.10.5'
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ thirdPartyAudit.enabled = false
configurations.all {
// conflict with spring-jcl
exclude group: "commons-logging", module: "commons-logging"
exclude group: 'com.fasterxml.jackson.core', module: 'jackson-core'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is supposed to be same resolutionStrategy.force as above? Otherwise, although all IT passed, our plugin will have problem at runtime. Please confirm and do sanity test by running all ITs with remote ES cluster with our plugin built from your branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=es-integrationtest -Dtests.class="*SQLCorrectnessIT" -Dhttps=true -Duser=admin -Dpassword=admin in #760

// enforce 1.1.3, https://www.whitesourcesoftware.com/vulnerability-database/WS-2019-0379
resolutionStrategy.force 'commons-codec:commons-codec:1.13'
resolutionStrategy.force 'com.google.guava:guava:29.0-jre'
Expand Down
4 changes: 2 additions & 2 deletions protocol/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ repositories {
dependencies {
// https://github.com/google/guava/wiki/CVE-2018-10237
compile group: 'com.google.guava', name: 'guava', version: '29.0-jre'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.10.4'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.4'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.10.5'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.5.1'
implementation 'com.google.code.gson:gson:2.8.6'
compile project(':core')
compile project(':elasticsearch')
Expand Down
2 changes: 1 addition & 1 deletion sql-jdbc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ repositories {

dependencies {
implementation group: 'org.apache.httpcomponents', name: 'httpclient', version: '4.5.6'
implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.7'
implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.5'
implementation group: 'com.amazonaws', name: 'aws-java-sdk-core', version: '1.11.452'

testImplementation('org.junit.jupiter:junit-jupiter-api:5.3.1')
Expand Down