Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enable Date type input in function Count() #917

Closed

Conversation

harold-wang
Copy link
Contributor

Issue #916 , if available:

Description of changes:

  • Add three input type (DATE, DATETIME, TIMESTAMP) in Count()
  • Add UT (DATE, DATETIME or TIMESTAMP) input type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh
Copy link
Member

This PR also includes code changes of #914 ?

@harold-wang
Copy link
Contributor Author

This PR also includes code changes of #914 ?

it should not.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #917 (be4e456) into develop (d170da3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #917   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
- Complexity      2149     2152    +3     
==========================================
  Files            216      216           
  Lines           4851     4858    +7     
  Branches         323      323           
==========================================
+ Hits            4844     4851    +7     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...sql/expression/aggregation/AggregatorFunction.java 100.00% <100.00%> (ø) 40.00 <3.00> (+3.00)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø) 122.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d170da3...be4e456. Read the comment docs.

@chloe-zh
Copy link
Member

This PR also includes code changes of #914 ?

it should not.

Could you merge the develop branch with latest commits to this branch?

@harold-wang
Copy link
Contributor Author

A new PR #918 was used to replace this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants