Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Disable sorting on workbench #900

Merged
merged 2 commits into from
Dec 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,9 @@ describe("<QueryResults with data/> spec", () => {
// It tests Tab button
await fireEvent.click(getAllByRole('tab')[5]);

// TODO: uncomment this test when sorting is fixed
// It tests sorting
await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
// await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: here and other places where lines are commented out, can we add TODO comments?


// It tests pagination
await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);
Expand Down Expand Up @@ -209,8 +210,9 @@ describe("<QueryResults with data/> spec", () => {
// It tests Tab button
await fireEvent.click(getAllByRole('tab')[5]);

// TODO: uncomment this test when sorting is fixed
// It tests sorting
await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
// await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);

// It tests pagination
await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);
Expand Down
6 changes: 3 additions & 3 deletions workbench/public/components/QueryResults/QueryResultsBody.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -601,9 +601,9 @@ class QueryResultsBody extends React.Component<QueryResultsBodyProps, QueryResul
<EuiTableHeaderCell
key={label}
width={colwidth}
onSort={this.onSort.bind(this, label)}
isSorted={this.props.sortedColumn === label}
isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
// onSort={this.onSort.bind(this, label)}
// isSorted={this.props.sortedColumn === label}
// isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
>
{label}
</EuiTableHeaderCell>
Expand Down
Loading