Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support double value in string format for GeoPoint #1066

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Mar 5, 2021

Signed-off-by: Peng Huo penghuo@gmail.com

Issue #, if available: #1064

Description of changes:

  1. Support the double value in string format for GeoPoint.
    Note: we are not supporting all the GeoPoint listed in here. We only support two type of geopoint now.
PUT my-index-000001/_doc/1
{
  "text": "Geo-point as an object",
  "location": { 
    "lat": 41.12,
    "lon": -71.34
  }
}
PUT my-index-000001/_doc/2
{
  "text": "Geo-point as an object",
  "location": { 
    "lat": "41.12",
    "lon": "-71.34"
  }
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo requested review from dai-chen and chloe-zh March 5, 2021 17:46
@penghuo penghuo added the enhancement New feature or request label Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1066 (4e196f5) into develop (4afff39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1066   +/-   ##
==========================================
  Coverage      99.89%   99.89%           
- Complexity      2408     2413    +5     
==========================================
  Files            236      236           
  Lines           5484     5504   +20     
  Branches         327      329    +2     
==========================================
+ Hits            5478     5498   +20     
  Misses             5        5           
  Partials           1        1           
Impacted Files Coverage Δ Complexity Δ
...ticsearch/data/utils/ElasticsearchJsonContent.java 100.00% <100.00%> (ø) 27.00 <6.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afff39...4e196f5. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@penghuo penghuo merged commit a56fc0b into opendistro-for-elasticsearch:develop Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants