remove isNonLiteral()

opendistro-for-elasticsearch · Dec 14, 2020 · 5dace04 · 5dace04
1 parent b3b8282
commit 5dace04
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/...main/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/AstAggregationBuilder.java b/...main/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/AstAggregationBuilder.java
@@ -125,7 +125,6 @@ private List<UnresolvedExpression> replaceGroupByItemIfAliasOrOrdinal() {
    */
   private Optional<UnresolvedExpression> findNonAggregatedItemInSelect() {
     return querySpec.getSelectItems().stream()
-                                     .filter(this::isNonLiteral)
                                      .filter(this::isNonAggregatedExpression)
                                      .filter(this::isNonLiteralFunction)
                                      .findFirst();
@@ -135,10 +134,6 @@ private boolean isAggregatorNotFoundAnywhere() {
     return querySpec.getAggregators().isEmpty();
   }
 
-  private boolean isNonLiteral(UnresolvedExpression expr) {
-    return !(expr instanceof Literal);
-  }
-
   private boolean isNonLiteralFunction(UnresolvedExpression expr) {
     // The base case for recursion
     if (expr instanceof Literal) {