-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage 80.51% 80.51%
Complexity 388 388
=========================================
Files 62 62
Lines 1468 1468
Branches 130 130
=========================================
Hits 1182 1182
Misses 239 239
Partials 47 47 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to change here as well https://github.com/opendistro-for-elasticsearch/k-NN/blob/master/gradle.properties#L16.
Even though this field is not used but just to keep it consistent.
Add support for ES 7.10.2
Ack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes.
Upgrade to ES 7.10.2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.