-
Notifications
You must be signed in to change notification settings - Fork 45
move metadata to config index #368
move metadata to config index #368
Conversation
Codecov Report
@@ Coverage Diff @@
## opendistro-1.11 #368 +/- ##
=====================================================
+ Coverage 76.08% 76.36% +0.27%
- Complexity 873 891 +18
=====================================================
Files 123 124 +1
Lines 4533 4794 +261
Branches 676 701 +25
=====================================================
+ Hits 3449 3661 +212
- Misses 713 746 +33
- Partials 371 387 +16 Continue to review full report at Codecov.
|
High level comment - worried about perf issues by moving it into config index. Job scheduler does have a postIndex subscriber to the config index which is executed every time a doc is added/updated. Imagining someone with 10k indices every 1 minute which means 20k updates per minute (each ISM execution ends up doing 2 updates to metadata for starting/closing a transaction) which are all triggering that callback which then has to check if it's of a job type to schedule (which it isn't). Alternatively we can consider another ism index which is purely for metadata which won't have this listener attached... we could have both rollup and ism metadata in there instead of the config index. Some testing could be good to see if this is a real concern. |
Issue #, if available:
#207
Description of changes:
Previously we save job metadata to cluster state, which will be a performance constraint when there are thousands of parallel running job. Now we save job metadata to our configuration index to relieve this performance concern.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.