Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Bug fix: getRollups API, rollup jobs landing page #154

Merged
merged 16 commits into from
Jan 28, 2021
Merged

Conversation

annie3431
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • getRollups API fix: modify format of node API to take optional parameters.
  • Modify rollup jobs landing page to show fields correctly and have working sorting function.
  • Clean up code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@annie3431
Copy link
Contributor Author

Output after running yarn run test:jest

Test Suites: 32 passed, 32 total
Tests:       167 passed, 167 total
Snapshots:   28 passed, 28 total
Time:        156 s, estimated 383 s
Ran all test suites.
✨  Done in 158.03s.

bowenlan-amzn
bowenlan-amzn previously approved these changes Jan 27, 2021
@annie3431
Copy link
Contributor Author

annie3431 commented Jan 27, 2021

Unit tests and E2E cypress tests have passed in previous workflow run: https://github.com/opendistro-for-elasticsearch/index-management-kibana-plugin/runs/1772682858

@annie3431 annie3431 marked this pull request as ready for review January 27, 2021 05:04
@annie3431 annie3431 added bug Something isn't working maintenance improves code quality, but not the product labels Jan 27, 2021
@annie3431 annie3431 merged commit 3b32210 into master Jan 28, 2021
@annie3431 annie3431 deleted the getRollups-fix branch January 28, 2021 06:13
@bowenlan-amzn bowenlan-amzn removed the maintenance improves code quality, but not the product label Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants