This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Cleaning up settings name, Stats URL and redacting node details #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
============================================
- Coverage 82.75% 82.63% -0.13%
+ Complexity 545 541 -4
============================================
Files 60 60
Lines 2053 2038 -15
Branches 149 145 -4
============================================
- Hits 1699 1684 -15
Misses 245 245
Partials 109 109
Continue to review full report at Codecov.
|
Bukhtawar
previously approved these changes
Feb 13, 2021
Bukhtawar
reviewed
Feb 13, 2021
| @@ -40,7 +40,7 @@ | |||
| private volatile int maxRunningSearches; | |||
| public static final int DEFAULT_MAX_RUNNING_SEARCHES = 20; | |||
| public static final Setting<Integer> MAX_RUNNING_SEARCHES_SETTING = Setting.intSetting( | |||
| "opendistro_asynchronous_search.max_running_searches", DEFAULT_MAX_RUNNING_SEARCHES, 0, Setting.Property.Dynamic, | |||
| "opendistro.asynchronous_search.max_running_searches", DEFAULT_MAX_RUNNING_SEARCHES, 0, Setting.Property.Dynamic, | |||
There was a problem hiding this comment.
Should we rename this to node.max_running_searches
There was a problem hiding this comment.
node_concurrent_running_searches to follow other setting conventions
Bukhtawar
reviewed
Feb 14, 2021
psychbot
approved these changes
Feb 14, 2021
| "opendistro_asynchronous_search.max_running_searches", DEFAULT_MAX_RUNNING_SEARCHES, 0, Setting.Property.Dynamic, | ||
| Setting.Property.NodeScope); | ||
| private volatile int nodeConcurrentRunningSearches; | ||
| public static final int NODE_CONCURRENT_RUNNING_SEARCHES = 20; |
There was a problem hiding this comment.
Can we add something to variable name to signify this is max allowed per node ?
anshul291995
approved these changes
Feb 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opendistro.asynchronous_searchstatstostatsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.