This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding RestActions support Create/Update Detector API #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
============================================
+ Coverage 71.60% 71.68% +0.08%
- Complexity 1352 1367 +15
============================================
Files 153 157 +4
Lines 6406 6513 +107
Branches 490 493 +3
============================================
+ Hits 4587 4669 +82
- Misses 1587 1609 +22
- Partials 232 235 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -254,7 +254,8 @@ List<String> jacocoExclusions = [ | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.StatsAnomalyDetectorTransportAction', | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.DeleteAnomalyDetectorTransportAction*', | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.GetAnomalyDetectorTransportAction*', | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.GetAnomalyDetectorResponse' | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.GetAnomalyDetectorResponse', | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.IndexAnomalyDetectorRequest' | |||
There was a problem hiding this comment.
Added IndexAnomalyDetectorRequest using Powermock but JaCoCo doesnt read lines covered by Powermock tests.
ylwu-amzn
reviewed
Oct 12, 2020
...java/com/amazon/opendistroforelasticsearch/ad/rest/handler/AnomalyDetectorActionHandler.java
Show resolved
Hide resolved
ylwu-amzn
reviewed
Oct 12, 2020
| @@ -132,11 +141,15 @@ public IndexAnomalyDetectorActionHandler( | |||
| */ | |||
| public void start() throws IOException { | |||
| if (!anomalyDetectionIndices.doesAnomalyDetectorIndexExist()) { | |||
| System.out.println("AnomalyDetector Indices do not exist"); | |||
There was a problem hiding this comment.
Remove System.out.println, check other places too
There was a problem hiding this comment.
Sure.. there are other debugging logs as well. Will remove them.
ylwu-amzn
reviewed
Oct 12, 2020
...com/amazon/opendistroforelasticsearch/ad/rest/handler/IndexAnomalyDetectorActionHandler.java
Outdated
Show resolved
Hide resolved
|
Could you rebase with master to only have the changes related to create/update detector? |
ylwu-amzn
reviewed
Oct 12, 2020
...va/com/amazon/opendistroforelasticsearch/ad/transport/GetAnomalyDetectorTransportAction.java
Outdated
Show resolved
Hide resolved
Sure, just rebased and merged master changes into this PR. |
ylwu-amzn
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding RestActions support Create/Update Detector API which is needed to support AD FGAC
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.