This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add match and count APIs #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
approved these changes
Oct 22, 2020
| @@ -735,6 +737,45 @@ const getAnomalyResults = async ( | |||
| } | |||
| }; | |||
|
|
|||
| const matchDetector = async ( | |||
There was a problem hiding this comment.
just curious: what does this API do? search detector by name?
There was a problem hiding this comment.
basically returns true or false if the passed params match any existing detector name, without returning any extra detector information that a user may not have access to if using FGAC
There was a problem hiding this comment.
See backend PR for more opendistro-for-elasticsearch/anomaly-detection#286
|
can you quickly check if e2e test passes? |
yizheliu-amazon
approved these changes
Oct 22, 2020
Getting a flaky test failing on my local, but these changes shouldn't affect it, I imagine it should still pass fine in the github runner |
saratvemulapalli
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds frontend support for the implemented
matchandcountAPIs (see here).These apis are used in 2 different parts for validation on the create/edit detector page, replacing the search API which caused a security leak by returning extra detector information for a user which they may not be supposed to have access to.
Notes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.