Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rajoute npm clean-install dans le README.md #203

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

bonjourmauko
Copy link
Contributor

@bonjourmauko bonjourmauko commented Nov 29, 2023

Fixes #107

Amélioration technique

Contexte

Lorsque je fais npm install && npm run build,
je m'attends à ce cela marche.

Problème

Parfois, cela ne marche pas :

6:07:40 PM: > ecospheres-front@0.0.0 build
6:07:40 PM: > vite build
6:07:40 PM: failed to load config from /opt/build/repo/vite.config.js
6:07:40 PM: error during build:
6:07:40 PM: Error: The package "@esbuild/linux-x64" could not be found, and is needed by esbuild.
6:07:40 PM: If you are installing esbuild with npm, make sure that you don"t specify the
"--no-optional" or "--omit=optional" flags. The "optionalDependencies" feature
6:07:40 PM: of "package.json" is used by esbuild to install the correct binary executable
6:07:40 PM: for your current platform.

Proposition de solution au problème

  • Améliorer la doc de prise en main.

Qu'est-ce qui change ?

Changements non techniques

  • 📖 Propose de toujours utiliser npm clean-install

Éléments supplémentaires de ma proposition

Depuis l'investigation faite par @streino sur #107, il semblerait qu'il s'agit d'un problème de cache.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 6c75ae9
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/65675aed3c1fdc000854bf1b
😎 Deploy Preview https://deploy-preview-203--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

edelagnier
edelagnier previously approved these changes Nov 29, 2023
Copy link
Contributor

@edelagnier edelagnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi.

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bonjourmauko bonjourmauko changed the title ci: rajoute eslint/linux-x64 aux optional dependencies ci: rajoute npm clean install dans le README.md Nov 29, 2023
@bonjourmauko bonjourmauko changed the title ci: rajoute npm clean install dans le README.md ci: rajoute npm clean-install dans le README.md Nov 29, 2023
@bonjourmauko bonjourmauko merged commit 0986d78 into main Nov 29, 2023
@bonjourmauko bonjourmauko deleted the ci/fix-esbuild branch November 29, 2023 17:38
@streino streino added documentation Tout ce qui touche à la documentation and removed ci labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Tout ce qui touche à la documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: build failure
3 participants