Pass param for pre-created socket to uvicorn #224
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the integration tests, the built image triggered the error below:
Looking for the function
serve_http()
invllm/entrypoints/launcher.py
, I found that a recent modification in PR #13113 (post vLLM v0.7.2) added an optional parametersock
to allow uvicorn to use a pre-created socket.We actually use the
serve_http()
function in/src/vllm_tgis_adapter/http.py
. Because of this, I added a parametersock=None
to maintain the same function signature we used before. I'm not sure if we need to use a pre-created socket for multi-GPU support or for something else.