Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODH Image build actions #4

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

z103cb
Copy link

@z103cb z103cb commented Apr 4, 2024

What this PR does / why we need it:
This PR add's ODH workflows to build and publish to quay.io training operator images

**Which issue(s) this PR fixe
Fixes # https://issues.redhat.com/browse/RHOAIENG-4838?filter=-1

Checklist:
Valided this work in my own fork, runs of this workflow can be seen here:

Images can be seen here:
https://quay.io/repository/laurentiu_bradin/training-operator?tab=tags

This workflow will need these secrets to be defined:

  • QUAY_USERNAME -- quay user name
  • QUAY_TOKEN -- quay encrypted token.
    Also this workflow will need this environment variable defined:
  • QUAY_REPO_NAME -- quay namespace / repo

@z103cb z103cb force-pushed the odh_release_action branch 2 times, most recently from c8e061b to 10e7ab9 Compare April 4, 2024 13:12
@anishasthana
Copy link
Member

I think we can build solely for amd64 for now, to keep things simple. Thoughts?

@z103cb
Copy link
Author

z103cb commented Apr 5, 2024

I think we can build solely for amd64 for now, to keep things simple. Thoughts?

The work is already done, I don't see any good reason (right now) as to why this would need to pulled out.

@zdtsw
Copy link
Member

zdtsw commented Apr 5, 2024

I think we can build solely for amd64 for now, to keep things simple. Thoughts?

The work is already done, I don't see any good reason (right now) as to why this would need to pulled out.

I think the idea is, we do not support any arch than x86_64 in ODH and RHOAI.
to add arm64 here can cause confusion.
Unless you want to run KFTO as an independent operator without ODH operator on arm64

@z103cb
Copy link
Author

z103cb commented Apr 5, 2024

I think we can build solely for amd64 for now, to keep things simple. Thoughts?

The work is already done, I don't see any good reason (right now) as to why this would need to pulled out.

I think the idea is, we do not support any arch than x86_64 in ODH and RHOAI. to add arm64 here can cause confusion. Unless you want to run KFTO as an independent operator without ODH operator on arm64

I want to be able to run the training operator on OpenShift local on arm64. The fact none of the other operators support arm64 is RPITA and reduces the usability of a RH stack.

I feel very strongly about having this architecture being supported.

@z103cb z103cb force-pushed the odh_release_action branch 2 times, most recently from de144ae to 7114cef Compare April 5, 2024 09:02
@astefanutti astefanutti force-pushed the dev branch 2 times, most recently from ec8d4fb to 005c2a0 Compare April 5, 2024 15:45
@z103cb z103cb force-pushed the odh_release_action branch 2 times, most recently from 24e1663 to 896f9a8 Compare April 8, 2024 10:47
@z103cb z103cb force-pushed the odh_release_action branch from 896f9a8 to 9e37b80 Compare April 8, 2024 11:52
@z103cb z103cb force-pushed the odh_release_action branch from 9e37b80 to 20006fe Compare April 8, 2024 12:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8600294475

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on odh_release_action at 42.877%

Totals Coverage Status
Change from base Build 8599984553: 42.9%
Covered Lines: 3753
Relevant Lines: 8753

💛 - Coveralls

Copy link
Member

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed all checks /LGTM

@anishasthana anishasthana merged commit f46d74d into opendatahub-io:dev Apr 8, 2024
16 checks passed
KPostOffice pushed a commit that referenced this pull request May 23, 2024
KPostOffice referenced this pull request in red-hat-data-services/training-operator May 23, 2024
Fiona-Waters pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants