-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODH Image build actions #4
Conversation
c8e061b
to
10e7ab9
Compare
I think we can build solely for amd64 for now, to keep things simple. Thoughts? |
The work is already done, I don't see any good reason (right now) as to why this would need to pulled out. |
I think the idea is, we do not support any arch than x86_64 in ODH and RHOAI. |
I want to be able to run the training operator on OpenShift local on arm64. The fact none of the other operators support arm64 is RPITA and reduces the usability of a RH stack. I feel very strongly about having this architecture being supported. |
de144ae
to
7114cef
Compare
ec8d4fb
to
005c2a0
Compare
24e1663
to
896f9a8
Compare
896f9a8
to
9e37b80
Compare
9e37b80
to
20006fe
Compare
Pull Request Test Coverage Report for Build 8600294475Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passed all checks /LGTM
What this PR does / why we need it:
This PR add's ODH workflows to build and publish to quay.io training operator images
**Which issue(s) this PR fixe
Fixes # https://issues.redhat.com/browse/RHOAIENG-4838?filter=-1
Checklist:
Valided this work in my own fork, runs of this workflow can be seen here:
Images can be seen here:
https://quay.io/repository/laurentiu_bradin/training-operator?tab=tags
This workflow will need these secrets to be defined:
QUAY_USERNAME
-- quay user nameQUAY_TOKEN
-- quay encrypted token.Also this workflow will need this environment variable defined:
QUAY_REPO_NAME
-- quay namespace / repo