Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status/conditions to FeatureTrackers #801

Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/feature/feature.go
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
  • Loading branch information
cam-garrison and bartoszmajsak authored Jan 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit df8338e2cea0efbb4c6efce90eb087fdd221dd5f
2 changes: 1 addition & 1 deletion pkg/feature/feature.go
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ func (f *Feature) Apply() (err error) {
// Verify all precondition and collect errors
var multiErr *multierror.Error
phase := featurev1.FeatureCreated
f.updateFeatureTrackerStatus(conditionsv1.ConditionDegraded, "False", phase, fmt.Sprintf("Applying feature %s", f.Name))
f.updateFeatureTrackerStatus(conditionsv1.ConditionProgressing, "True", phase, fmt.Sprintf("Applying feature %s", f.Name))
defer func() {
if err != nil {
f.updateFeatureTrackerStatus(conditionsv1.ConditionDegraded, "True", phase, err.Error())
Loading