Update codeflare component description #742
Conversation
Run "make bundle"
|
Hi @ronensc. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update comment: codeflare installed on the fly
* fix(codegen): ensures structs used in CRDs have deepcopy funcs (#740) - autogenerates deepcopy for each component - updates infrastructure types to have deepcopy gen * fix(ns): do not set owner ref for infra ns (#743) This change ensures that both h service mesh and kserve namespaces should be left untouched when deleting DSCI under the assumption that user could have customize them. They are only created when not found in the cluster. Few additional improvements: - opened up CreateNamespace func to pass options with additional metadata (such as labels) - fixed returned ns as it was returning non-cluster one in case it already existed - exports label marking ownership of the ns and uses it across the code base There's still quite a bit of technical debt/copy-paste around [namespace creation](https://github.com/opendatahub-io/opendatahub-operator/blob/14a980532d8992cb1d884ea698c7ac1d56dc3513/controllers/dscinitialization/utils.go#L39-L70), but I left it for another PR as this change is focused on fixing KServe installation. * Update codeflare component description (#742) * Update comment: codeflare installed on the fly --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com>
Description
After a discussion with @anishasthana, it was discovered that the description of the CodeFlare component in the manifests is not up-to-date. The current description indicates that the CodeFlare Operator should be installed in advance, but in reality, it will be installed on the fly.
This PR updates the description
How Has This Been Tested?
Merge criteria: