-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(make): ensures projects version of operator-sdk is used #695
fix(make): ensures projects version of operator-sdk is used #695
Conversation
- aligns make target to use the same commands as other tools - reverts accidental changes in bundle metadata
@@ -72,7 +72,7 @@ metadata: | |||
categories: AI/Machine Learning, Big Data | |||
certified: "False" | |||
containerImage: quay.io/opendatahub/opendatahub-operator:v2.1.0 | |||
createdAt: "2023-10-30T14:38:57Z" | |||
createdAt: "2023-8-23T00:00:00Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't ask... It's what operator SDK produces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's essentially the same as in the main
at this moment:
opendatahub-operator/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
Line 75 in 6acf1a9
createdAt: "2023-8-23T00:00:00Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…hub-io#695) (cherry picked from commit 78041ea)
Description
See #668 (comment)
Fixes #694
How Has This Been Tested?
make bundle
Merge criteria: