Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(api): shortname for CRD #650

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 19, 2023

dsc for DataScienceCluster
dsci for DataScienceClusterInitialization

Description

fix: #642

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.10.642
after install operator, check:

oc api-resources | grep opendatahub
odhapplications                                                              dashboard.opendatahub.io/v1                   true         OdhApplication
odhdocuments                                                                 dashboard.opendatahub.io/v1                   true         OdhDocument
datascienceclusters                   dsc                                    datasciencecluster.opendatahub.io/v1          false        DataScienceCluster
dscinitializations                    dsci                                   dscinitialization.opendatahub.io/v1           false        DSCInitialization
servicemeshresourcetrackers                                                  dscinitialization.opendatahub.io/v1           false        ServiceMeshResourceTracker
odhdashboardconfigs                                                          opendatahub.io/v1alpha                        true         OdhDashboardConfig

oc get dsci 
NAME      AGE   PHASE   CREATED AT
default   76s   Ready   2023-10-19T07:29:15Z

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from etirelli and LaVLaS October 19, 2023 05:50
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw requested review from VaishnaviHire and removed request for LaVLaS October 19, 2023 07:31
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 79958f1 into opendatahub-io:incubation Oct 20, 2023
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Oct 20, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 79958f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add short names for DSC and DSC-init
2 participants