Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[odh-2.2.0] Add acceleratorprofiles from dashboard as new CRD #570

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

VaishnaviHire
Copy link
Member

Signed-off-by: Wen Zhou wenzhou@redhat.com
(cherry picked from commit 56d5cff)

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 56d5cff)
@VaishnaviHire VaishnaviHire requested a review from zdtsw September 27, 2023 11:13
@openshift-ci openshift-ci bot requested review from etirelli and LaVLaS September 27, 2023 11:13
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdtsw
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw added the odh-1.10 label Sep 27, 2023
@VaishnaviHire VaishnaviHire merged commit 0d97ba2 into opendatahub-io:odh-2.2.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants