Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: change to delete CF resource is not required #554

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Revert: change to delete CF resource is not required #554

merged 1 commit into from
Sep 21, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 21, 2023

Description

revert changes for #510
tl;dr: handling done in CF operator, wont require action from ODH operator
detail https://github.com/opendatahub-io/opendatahub-operator/pull/511/files

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
Revert: change to delete CF resource is not required
1ea73f7 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
astefanutti
astefanutti approved these changes Sep 21, 2023
View reviewed changes
Copy link

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Sep 21, 2023
@zdtsw zdtsw added the odh-1.10 label Sep 21, 2023
VaishnaviHire
VaishnaviHire approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, astefanutti, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0b2bb98 into opendatahub-io:main Sep 21, 2023
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 29, 2023
@zdtsw @VaishnaviHire
Revert: change to delete CF resource is not required (opendatahub-io#554
ce329ff 
)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 0b2bb98)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 29, 2023
@zdtsw @VaishnaviHire
Revert: change to delete CF resource is not required (opendatahub-io#554
6edd305 
)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 0b2bb98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@anishasthana anishasthana anishasthana approved these changes

@astefanutti astefanutti astefanutti approved these changes

@etirelli etirelli Awaiting requested review from etirelli

Assignees

@astefanutti astefanutti

@anishasthana anishasthana

@VaishnaviHire VaishnaviHire

Labels
approved lgtm odh-1.10
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zdtsw @astefanutti @anishasthana @VaishnaviHire @openshift-merge-robot