chore: minor clean-ups #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
reviewed
Sep 14, 2023
zdtsw
reviewed
Sep 14, 2023
This reverts commit da574c4.
|
Thanks @bartoszmajsak for these fixes! Changes look good to me /lgtm |
VaishnaviHire
approved these changes
Sep 14, 2023
|
@VaishnaviHire thanks, I added one additional thing while cleaning up error handling, please take a look when you'll find some time |
Co-authored-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 29, 2023
* fix: handles err when checking managed RHODS * chore: fixes typos and godoc convention * chore: removes redundant pattern * chore: removes dead code * chore(deps): removes unused module * chore: fixes godoc to use documented function name first * chore: unifies receiver names * chore: wraps error instead of constructing new one * fix: removes rendundant _ exp from for loop * fix: removes redundant import alias * fix: removes unneeded string conversion * chore: switches file operations from depracated ioutil to os pkg * chore: swaps deprecated AddToScheme with Install * chore: handles ignored errors * Revert "chore: wraps error instead of constructing new one" This reverts commit da574c4. * chore: wraps errors using %w directive * chore: simplifies component error handling using multierr * chore: cleans up imports * chore: update docs in pkg/deploy/deploy.go Co-authored-by: Wen Zhou <wenzhou@redhat.com> --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit efe23f7)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 29, 2023
* fix: handles err when checking managed RHODS * chore: fixes typos and godoc convention * chore: removes redundant pattern * chore: removes dead code * chore(deps): removes unused module * chore: fixes godoc to use documented function name first * chore: unifies receiver names * chore: wraps error instead of constructing new one * fix: removes rendundant _ exp from for loop * fix: removes redundant import alias * fix: removes unneeded string conversion * chore: switches file operations from depracated ioutil to os pkg * chore: swaps deprecated AddToScheme with Install * chore: handles ignored errors * Revert "chore: wraps error instead of constructing new one" This reverts commit da574c4. * chore: wraps errors using %w directive * chore: simplifies component error handling using multierr * chore: cleans up imports * chore: update docs in pkg/deploy/deploy.go Co-authored-by: Wen Zhou <wenzhou@redhat.com> --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit efe23f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on a Service Mesh component, I discovered several areas in the codebase that could be slightly improved. This pull request aims to address those issues for better code quality and maintainability.
Changes
AddToSchemeandioutilfunctionsThese changes are proposed separately from the component work, so the final PR won't be that large, but also to speed up their review and potential inclusion into the main codebase.
How Has This Been Tested?
make testMerge criteria: