Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: downstream codeflare has a different operator name than upstream #509

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 4, 2023

Description

ref: https://issues.redhat.com/browse/RHODS-11706

How Has This Been Tested?

local ODH build image: quay.io/wenzhou/opendatahub-operator-catalog:v2.9.5-11706

a bit difficult to test this, because i need a rhods subscription to test non-ODH case.
maybe easier to use this local rhods build image: quay.io/wenzhou/opendatahub-operator-catalog:v2.9.5-11706-2

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested a review from winklerm September 4, 2023 15:04
@zdtsw zdtsw force-pushed the issue/rhods-11706 branch from 1381502 to 74b8419 Compare September 5, 2023 04:21
@zdtsw
Copy link
Member Author

zdtsw commented Sep 5, 2023

/test

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

@zdtsw: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test ci-index
  • /test images
  • /test opendatahub-operator-e2e
  • /test opendatahub-operator-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zdtsw
Copy link
Member Author

zdtsw commented Sep 5, 2023

/test all

@winklerm
Copy link

winklerm commented Sep 5, 2023

/lgtm

Copy link
Contributor

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etirelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@zdtsw zdtsw merged commit d33604a into opendatahub-io:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants