Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBAC permission for resource #492

Closed
wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 29, 2023

Description

add more comments
remove securityistio.io ref: opendatahub-io/odh-manifests#922
remove telemetry,istio.io ref: opendatahub-io/odh-manifests#922

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- add more comments
- remove securityistio.io
- remove telemetry,istio.io
- remove downstream only required permission

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire August 29, 2023 08:37
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign etirelli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw changed the base branch from permission_update3 to main August 29, 2023 08:38
@zdtsw
Copy link
Member Author

zdtsw commented Aug 29, 2023

close, as included in #485

@zdtsw zdtsw closed this Aug 29, 2023
grdryn pushed a commit to grdryn/opendatahub-operator that referenced this pull request Nov 28, 2024
…o#1281) (opendatahub-io#492)

* update: remove dsp with v1(tekton)backend related code

- images
- tekton rbac
- descriptions

---------
(cherry picked from commit 133b710)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Humair Khan <HumairAK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant