Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: move deploy manifests only for non-ODH to block #459

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 22, 2023

Description

PathISVSM PathODHDashboardConfig PathOVMS these are only applicable for downstream
fix enable dashboard error from missing manifests

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.8.22-1

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire August 22, 2023 07:45
@zdtsw zdtsw requested review from etirelli and VaishnaviHire and removed request for LaVLaS and VaishnaviHire August 22, 2023 07:45
@zdtsw
Copy link
Member Author

zdtsw commented Aug 22, 2023

0/21 nodes are available :D

@zdtsw
Copy link
Member Author

zdtsw commented Aug 22, 2023

/test ci-index images opendatahub-operator-pr-image-mirror

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

@zdtsw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index b65d2a9 link true /test ci-index
ci/prow/images b65d2a9 link true /test images
ci/prow/opendatahub-operator-pr-image-mirror b65d2a9 link true /test opendatahub-operator-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etirelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 10e9232 into main Aug 22, 2023
@zdtsw
Copy link
Member Author

zdtsw commented Aug 22, 2023

merge change , test failed due to lack of available nodes in the cluster.

@zdtsw zdtsw deleted the fix_enabled branch September 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants