-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update permission on operator level #447
Conversation
cf8ebdd
to
bffa2b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Since we are doing serverside apply, resources should have
patch
permissions underverbs
-
To successfully get deleted resources should also have
delete
permissions
latest test to set:
get |
to solve dashboard and modelmesh secret issue, we need |
- remove dsci and dsc viewer and editor which are not in use Signed-off-by: Wen Zhou <wenzhou@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
ref: #422
also add MANIFEST_RELEASE to pass into image build if it is done by "make image" otherwise it is using v1.8 from odh-manifests
How Has This Been Tested?
test: image: 'quay.io/wenzhou/opendatahub-operator:dev-2.8.15-40'
PS: if enable "ray" for the current ODH odh-manifests, we see reconcile from operator v2.
so we need to get opendatahub-io/odh-manifests#910 into "master" odh-manifests to finalize the function. but from operator perspective, permissions are ready.
Merge criteria: