Update e2e test: timeout + ray + logging #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etirelli
reviewed
Aug 21, 2023
tests/e2e/controller_setup_test.go
Outdated
| @@ -60,18 +60,18 @@ func NewTestContext() (*testContext, error) { | |||
| // Lastly if none of them are set, it uses $HOME/.kube/config to create the client. | |||
| config, err := ctrlruntime.GetConfig() | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error creating the config object %v", err) | |||
| return nil, fmt.Errorf("Error to config object %v", err) | |||
There was a problem hiding this comment.
@zdtsw is there a reason to upcase the starting letter in error messages? the recommended best practice is to have all error messages start with lower case.
- more timeout due to new components (for in sequence run) - change validat component to run in concurrent - add Ray in the testing - logs for error message - rename functions to align names - set skip-deletion=false to test this case Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
took 761s (>10m)
after change to run in parallel took 300s
Merge criteria: