Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncommenting Ray component after fix to the ray manifests. fixes #369 #414

Merged

Conversation

etirelli
Copy link
Contributor

@etirelli etirelli commented Aug 3, 2023

Uncommenting Ray component after fix to the ray manifests. fixes #369

How Has This Been Tested?

Tested manually in the cluster using the new ray manifest after the following fix:

opendatahub-io/distributed-workloads@a65afe8

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from cfchase and LaVLaS August 3, 2023 18:42
@etirelli etirelli requested review from zdtsw and VaishnaviHire and removed request for cfchase and LaVLaS August 3, 2023 18:52
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@VaishnaviHire
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit dad3b0c into opendatahub-io:feature-rearchitecture Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants